Fix build #574
Closed
Fix build #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing a test against a cloud API is not possible in some environments. It's still useful to run a test suite in those cases, just not the online parts of the test. Most of the cloud APIs already require an API key, and if one is not provided then the online part of those APIs won't be tested. The only exception seems to be the Google APIs. Add a SKIP_ONLINE environment variable to skip those bits.
…, so allow for that as well.
|
Thank you for this pull request. e693e43 deserves to be merged but sorry, I was unaware of this and fixed the test at 58b05d4. About 28adbf2, the tests related the Google cloud API was failing due to a change in the return value of the I think there is some validity to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes