[Credix] Minting/Redeeming/CollectProfit IXs #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crypto-vincent
changed the title
Orelsanpls
reviewed
Dec 13, 2022
pages/dao/[symbol]/proposal/components/instructions/UXD/EditIdentityDepository.tsx
Show resolved
Hide resolved
| .min(0, 'Redeemable amount under management cap should be min 0'), | ||
| }); | ||
|
|
||
| const RegisterCredixLpDepository = ({ |
There was a problem hiding this comment.
Name should be EditCredixLpDepository
| } | ||
| error={formErrors['collateralName']} | ||
| > | ||
| <SelectOptionList list={getDepositoryMintSymbols(connection.cluster)} /> |
There was a problem hiding this comment.
Credix is only USDC for now and most likely also in the future, you could simplify all form by removing Collateral selection
There was a problem hiding this comment.
Yeah agreed, I was thinking about this too, but devnet has a special collateral that is different from mercurial, i was unsure what to do as I didnt want to hardcode too much things
|
Was able to generate transactions proposals that looks good!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR adds integration with the onchain credix smart contract by minting UXD when depositing collateral in credix and burning UXD when withdrawing collateral from credix
New instructions set:
register_credix_lp_depositorymint_with_credix_lp_depositoryredeem_from_credix_lp_depositorycollect_profit_of_credix_lp_depositoryedit_credix_lp_depositoryPR Combo:
Generated transactions: