Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection for GeoDataFrame engine in plotting routines #987

Merged
merged 17 commits into from
Oct 10, 2024
Merged

Selection for GeoDataFrame engine in plotting routines #987

merged 17 commits into from
Oct 10, 2024

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Oct 4, 2024 •
edited
Loading

Closes #988

Overview

@philipc2 philipc2 linked an issue Oct 4, 2024 that may be closed by this pull request
Select engine for GeoDataFrame when plotting #988
Closed
@philipc2 philipc2 marked this pull request as ready for review October 4, 2024 03:10
@philipc2 philipc2 self-assigned this Oct 4, 2024
aaronzedwick
aaronzedwick reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@aaronzedwick aaronzedwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had a few questions.

uxarray/grid/grid.py Outdated Show resolved Hide resolved
uxarray/grid/geometry.py Show resolved Hide resolved
test/test_plot.py Show resolved Hide resolved
aaronzedwick
aaronzedwick approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@aaronzedwick aaronzedwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, nice work Philip!

erogluorhan
erogluorhan approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@philipc2 philipc2 merged commit 691999b into main Oct 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erogluorhan erogluorhan erogluorhan approved these changes

@aaronzedwick aaronzedwick aaronzedwick approved these changes

@rajeeja rajeeja Awaiting requested review from rajeeja

Assignees

@philipc2 philipc2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select engine for GeoDataFrame when plotting
3 participants
@philipc2 @erogluorhan @aaronzedwick