Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Grid File Format as Attribute #968

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Include Grid File Format as Attribute #968

merged 4 commits into from
Sep 18, 2024

Conversation

rytam2
Copy link
Collaborator

@rytam2 rytam2 commented Sep 18, 2024

Closes #933

Overview

Added attribute that describes grid file format when loading grid with ux.grid.
self._ds.assign_attrs({"source_grid_spec": self.source_grid_spec})

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

Examples

  • Any new notebook examples added to docs/examples/ folder
  • Clear the output of all cells before committing
  • New notebook files added to docs/examples.rst toctree
  • New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

@rytam2 rytam2 self-assigned this Sep 18, 2024
@philipc2 philipc2 marked this pull request as ready for review September 18, 2024 18:40
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@philipc2 philipc2 merged commit 2b60860 into main Sep 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Grid File Format as Attribute when loading Grid
2 participants