Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODECOV_TOKEN to ci.yml to fix Codecov uploads #791

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

erogluorhan
Copy link
Member

Closes #703

Overview

This PR adds "CODECOV_TOKEN" into ci.yml (CODECOV_TOKEN has just been added to the repo secrets)

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview

@erogluorhan erogluorhan added bug Something isn't working CI Continuous Integration labels May 16, 2024
@erogluorhan erogluorhan changed the title Add CODECOV_TOKEN to ci.ysaml to fix Codecov uploads Add CODECOV_TOKEN to ci.yml to fix Codecov uploads May 16, 2024
@erogluorhan erogluorhan requested review from rajeeja, anissa111 and philipc2 and removed request for anissa111 May 16, 2024 02:00
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Philip Chmielowiec <[email protected]>
@erogluorhan erogluorhan requested a review from philipc2 May 16, 2024 02:29
Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

@philipc2 philipc2 merged commit 318f3f6 into main May 16, 2024
26 checks passed
@philipc2
Copy link
Member

Looks to be working as expected now!

https://app.codecov.io/gh/UXARRAY/uxarray/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov upload failures
2 participants