Compare and Swap Holoviews Extension #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
philipc2
changed the title
erogluorhan
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Thanks very much for handling this! Overall I like it and will approve soon. Just couple things:
- See the inline comment
- I am wondering how the cookbook would render with this. Did you (or if not, could you) install UXarray from this branch in a local copy of the cookbook and see how its plots rendering? Though, this might not even be needed, I just checked the usage examples rendered in this PR, and I think the issues seem resolved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #734
Overview
hv.extensionby keeping track of the previous backend and only callinghv.extensionwhen a swap occurs.