Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup ASV Benchmarking #694

Merged
merged 20 commits into from
Feb 13, 2024
Merged

Setup ASV Benchmarking #694

merged 20 commits into from
Feb 13, 2024

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Feb 8, 2024

Closes #420

Overview

Sample Run (local)

Accomplished by running the asv run command in the uxarray/benchmarks directory

image

@philipc2 philipc2 self-assigned this Feb 8, 2024
@philipc2 philipc2 added testing Test Cases CI Continuous Integration labels Feb 8, 2024
@philipc2 philipc2 changed the title DRAFT: Setup ASV Benchmarking Setup ASV Benchmarking Feb 8, 2024
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks right to me for this step. I might consider adding some stuff to your .gitignore for less mess with local runs, but that's not something I'm going to insist you should include here.

@philipc2 philipc2 marked this pull request as ready for review February 8, 2024 19:57
@philipc2
Copy link
Member Author

philipc2 commented Feb 8, 2024

This all looks right to me for this step. I might consider adding some stuff to your .gitignore for less mess with local runs, but that's not something I'm going to insist you should include here.

Good suggestion!

@philipc2 philipc2 linked an issue Feb 8, 2024 that may be closed by this pull request
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool! Just a single comment below

cp -r benchmarks/results/ uxarray-asv/
cd uxarray-asv
git config --local user.email "[email protected]"
git config --local user.name "philipc2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious if this could be handled in a way independent of individual username/email

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into it! There should be a way to handle this using the UXarray organization.

Copy link
Member Author

@philipc2 philipc2 Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I've read, we still need to have a user & email of someone that is authorized to the repository in order to commit.

However, I've been able to successfully use a token from the UXarray organization for pushing, instead of a personal one linked to my account.

I think this should be fine?

EDIT:

Thanks to @anissa111 suggestion, I've stored the user name and email as secrets instead of directly exposing them.

@erogluorhan erogluorhan merged commit 871e270 into main Feb 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration testing Test Cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect ASV Benchmarking to CI Timing and Memory Benchmarking using Airspeed Velocity (ASV)
3 participants