-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup ASV Benchmarking #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks right to me for this step. I might consider adding some stuff to your .gitignore for less mess with local runs, but that's not something I'm going to insist you should include here.
Good suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool! Just a single comment below
cp -r benchmarks/results/ uxarray-asv/ | ||
cd uxarray-asv | ||
git config --local user.email "[email protected]" | ||
git config --local user.name "philipc2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious if this could be handled in a way independent of individual username/email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into it! There should be a way to handle this using the UXarray organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've read, we still need to have a user & email of someone that is authorized to the repository in order to commit.
However, I've been able to successfully use a token from the UXarray organization for pushing, instead of a personal one linked to my account.
I think this should be fine?
EDIT:
Thanks to @anissa111 suggestion, I've stored the user name and email as secrets instead of directly exposing them.
Closes #420
Overview
Sample Run (local)
Accomplished by running the
asv run
command in theuxarray/benchmarks
directory