-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zonal face weights at constant lat #555
Zonal face weights at constant lat #555
Conversation
…hub.com/hongyuchen1030/uxarray into Helper_face_edge_connectivity_cartesian
…hub.com/hongyuchen1030/uxarray into Helper_face_edge_connectivity_cartesian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re current CI failures:
With the commit entitled "WIP" on the Feb 4th this year, several lines of codes seem to have been added. The following code block:
unique_intersection_lonlat = np.array(
[node_xyz_to_lonlat_rad(pt.tolist()) for pt in unique_intersection]
)
> unique_intersection_lonlat = unique_intersection_lonlat.append(
[2 * np.pi, latitude_rad]
)
apparently creates a numpy.ndarray
then attempts to .append()
into that, which results in
AttributeError: 'numpy.ndarray' object has no attribute 'append'
FYI: The last successful CI actions before the above commit seems to be Merge branch 'main' into zonal_face_weights_at_constantlat, which was on Jan 16.
Thanks for your information. Yeah I also noticed that this was the cause. So this syntax is actually valid before. I assume it was the version upgrade that makes it corrupts. I am still working on fixing it since I have been working on other research project recently. |
I think you intended to use |
I guessed the same thing before. But when I tried to fix it by using this |
for more information, see https://pre-commit.ci
…t' into zonal_face_weights_at_constantlat
for more information, see https://pre-commit.ci
…t' into zonal_face_weights_at_constantlat # Conflicts: # uxarray/grid/intersections.py
…t' into zonal_face_weights_at_constantlat
I have cleaned up and fixed the CI for this branch and it is mostly ready to go now. However, the read-doc failed is currently failing because the module
|
Thanks for the revisions! Giving this a look through now and I'll look into what's causing the RTD failures. |
Thank you very much! I just fixed a typo in the .rst file, I think the read-docs works now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! Thanks for addressing all the comments! Documentation looks good after your fix too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks for addressing all the issues!
Closes #544
Overview
_get_zonal_face_weights_at_constlat
method has been added to calculate the weight of each face at a constant latitude.Expected Usage
PR Checklist
General
Testing
Documentation
_
) and have been added todocs/internal_api/index.rst
docs/user_api/index.rst