Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiprecision coordinates conversion #326

Conversation

hongyuchen1030
Copy link
Contributor

@hongyuchen1030 hongyuchen1030 commented May 23, 2023

Finish the 2st step of #318

Grid Pre-processing

  • Precise spherical and cartesian coordinates conversion

@hongyuchen1030 hongyuchen1030 self-assigned this May 23, 2023
@hongyuchen1030 hongyuchen1030 marked this pull request as draft May 23, 2023 21:07
@hongyuchen1030 hongyuchen1030 added the new feature New feature or request label May 23, 2023
@hongyuchen1030 hongyuchen1030 linked an issue Jun 6, 2023 that may be closed by this pull request
@philipc2 philipc2 added the multiprecision Arbitrary-precision Arithmetic Implementations label Jun 14, 2023
@hongyuchen1030 hongyuchen1030 marked this pull request as ready for review June 15, 2023 00:34
@hongyuchen1030 hongyuchen1030 added the help wanted Extra attention is needed label Jun 15, 2023
@hongyuchen1030
Copy link
Contributor Author

@aaronzedwick Can you also help me merge the redesign into this branch as well? Thank you very much.

@philipc2
Copy link
Member

@hongyuchen1030

I'd suggest merging multiprecision_unique_coords_detection_through_verts into this branch instead since we already updated that one to account for the redesign.

@hongyuchen1030
Copy link
Contributor Author

@hongyuchen1030

I'd suggest merging multiprecision_unique_coords_detection_through_verts into this branch instead since we already updated that one to account for the redesign.

Got it. Thank you very much for your help. @aaronzedwick , can you help me work with this as well? Thank you very much

@aaronzedwick
Copy link
Member

I can try and help, I have actually been having some trouble merging my from_ds branch with the redesign as well. Once I get some time I will try and see if I can get that done and hopefully, I will have learned how to from that.

@philipc2 philipc2 changed the base branch from main to multi_precision July 18, 2023 18:02
@hongyuchen1030 hongyuchen1030 removed the multiprecision Arbitrary-precision Arithmetic Implementations label Oct 24, 2023
@hongyuchen1030 hongyuchen1030 added the multiprecision Arbitrary-precision Arithmetic Implementations label Oct 24, 2023
@philipc2
Copy link
Member

@hongyuchen1030

Considering the work in #748, should we close this pull request and consider re-visiting this in the future.

At some point, I'd like to check in on the general state of multiprecision support. There have been a lot of changes to the structure of our tool since that last time we looked at it.

There also isn't an issue directly related to the implementation here. Would you mind creating one when you have some time.

@hongyuchen1030
Copy link
Contributor Author

@hongyuchen1030

Considering the work in #748, should we close this pull request and consider re-visiting this in the future.

At some point, I'd like to check in on the general state of multiprecision support. There have been a lot of changes to the structure of our tool since that last time we looked at it.

There also isn't an issue directly related to the implementation here. Would you mind creating one when you have some time.

Thanks for your information. We can just close it at this point.

@philipc2 philipc2 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed multiprecision Arbitrary-precision Arithmetic Implementations new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants