Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL correctness fixes and other simplification #91

Merged
merged 28 commits into from
Mar 6, 2021
Merged

SQL correctness fixes and other simplification #91

merged 28 commits into from
Mar 6, 2021

Conversation

srsuryadev
Copy link
Contributor

Summary

  • Handled 0/1 optimization in the SQLite3 records to hustle storage.
  • BETWEEN operators handled as <= and >= operators
  • Lazy Table class simplification and additional assertion
  • Resolver fix to support additional aggregation operator in the query (e.g COUNT, AVG, ..)
  • Functionality to support callback fn in returning the result.

Important changes are in files: storage/block.cc, storage/cmemlog.c, resolver/cresolver.c, operators/utils/lazy_table.cc

NOTE: Thought of creating another pull request for the continued contribution of end-to-end SQL tests. (Since this PR is already large). I will create it once it is merged, to avoid redundant commit history (since these commits will be squashed on merging)

@srsuryadev
adding ssb load function
a138657
@srsuryadev
added ssb query driver
ba8b48d
@srsuryadev
add predicate.h in resolver
6121c36
@srsuryadev
add the hustle resolver operators
3509468
@srsuryadev
add resolver module in the hustle_src_benchmark
7f98040
@srsuryadev
remove sqlite3 header in ssb queries
7318a68
@srsuryadev
pass serial type lens instead of bytewidths
d5d8252
@srsuryadev
fix the record read for optimized bytewidth for 0/1
1456b4d
@srsuryadev
resolver fix for support for other agg functions
152179d
@srsuryadev
SSB Driver fix
790c1fb
@srsuryadev
SSB query fixes
f9d5424
@srsuryadev
remove unused code in hash_aggregate
3551a94
@srsuryadev
Lazy table simplification of methods and refactor
32c0011
@srsuryadev
revert the sqlite3 to hustle mode
6a485e5
@srsuryadev
Basic Benchmark test
8ae8f45
@srsuryadev
callback function support in sql execution for results
5d1a143
@srsuryadev
lazy table fixes on assertion
f6cfc87
@srsuryadev
rename and move benchmark test to sql test
dd5e78f
@srsuryadev
add sql test load
c786ce4
@srsuryadev
Block callback support for results fix
bbc22e2
@srsuryadev
SQL test - end to end
710b25a
@srsuryadev
add license headers in new files
432887a
@srsuryadev
move - sql test to diff branch (delete)
bef62f5
@srsuryadev
simplification and refactor of code
5d065b4
@srsuryadev
fixes in the command line
95a43de
@srsuryadev
Update Readme.md
009c261
@srsuryadev
benchmark cmd msg
09f5b0c
@srsuryadev
driver reformatting and removing old benchmark code
e7e48e0
@srsuryadev srsuryadev linked an issue Mar 6, 2021 that may be closed by this pull request
SQL Issues #88
Open
4 tasks
@srsuryadev srsuryadev merged commit f8e779d into master Mar 6, 2021
@srsuryadev srsuryadev deleted the ssb-validation-2 branch March 6, 2021 23:49
@srsuryadev srsuryadev mentioned this pull request Mar 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pateljm pateljm pateljm approved these changes

@mprammer mprammer Awaiting requested review from mprammer

@GindaChen GindaChen Awaiting requested review from GindaChen

@johnchronis johnchronis Awaiting requested review from johnchronis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Issues
2 participants
@srsuryadev @pateljm