Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUEST not giving same output as DQM and TRIAD when there are only a few stars visible and there is centroid error #110

Open
markasoftware opened this issue Apr 9, 2023 · 0 comments

Comments

@markasoftware
Copy link
Member

For example, (testing on commit ad863b2)

./lost database --kvector --kvector-max-distance 15 --min-mag 5.5 --output bbb.dat

./lost pipeline --generate 1 --centroid-algo cog --star-id-algo py --attitude-algo quest --database bbb.dat --print-attitude -

shows a different (and incorrect) result compared to

./lost pipeline --generate 1 --centroid-algo cog --star-id-algo py --attitude-algo dqm --database bbb.dat --print-attitude -

Why didn't we catch this earlier? Well, QUEST still seems to work fine when there's no centroid error (eg if you disabled centroid-algo cog above), and also seems to work okay when there are many stars visible (eg, set --generate-saturation-photons 50 in the above examples). But I recently changed the default image generation parameters to put less stars per photo, revealing the issue.

Pinging @karenhaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant