-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue423 durack1 fix vacumm dependencies #1089
Issue423 durack1 fix vacumm dependencies #1089
Conversation
@doutriaux1 @aashish24 ok this looks fine (just double checked the dependencies for configobj and six and confirmed they're ok) - so please merge once you've reviewed. @doutriaux1 I'm not sure that six has a dependency on pip - which is what was already in the file six_deps.cmake - its setup.py lists no dependencies.. |
Okay, I will review it in next few hours and will get it merged.. |
@aashish24 great, as noted above it could be a good idea to confirm the dependencies for six, I think pip can be removed.. |
@aashish24 @doutriaux1 let's wait with this PR until we get an all clear from @stefraynaud, apparently pytz was needed in the most recent vacumm version. |
@stefraynaud, so we currently have: In particular it's not clear to me whether paramiko, xlw or PIL are required? For reference: http://relay.actimar.fr/~raynaud/vacumm/user.install.prereq.html |
@durack1 I will commit a 2.5.1 version tomorrow that will remove the dependency to pytz. paramiko, xlw or PIL are not required. |
@stefraynaud great thanks for clarifying, I'll download your 2.5.1 sources and update the tar ball on the server when it's available and then this PR should be good to go.. |
@durack1 since we provide sphinx why not add it to the dep list? It will only change the order in which it is built and should give us a more complete version in case @stefraynaud checks for it at install time. Same for seawater |
@doutriaux1 the additional packages are not included in the existing ALL builds: |
I see |
@durack1 Vacumm 2.5.1 is released. |
@stefraynaud I'll pull down the upddate tarball and revise the PR today, hopefully this might sneak under the 2.2 milestone.. |
@durack1 I will try to out it in |
@doutriaux1 it's updated and good to go! |
@@ -0,0 +1 @@ | |||
set(vacumm_deps ${python_pkg} ${numpy_pkg} ${scipy_pkg} ${matplotlib_pkg} ${basemap_pkg} ${configobj_pkg}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no seawater?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no setuptools? if there's a setup.py it probably needs setuptools (distutils)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seawater isn't a hard dependency - only for advanced diags: http://relay.actimar.fr/~raynaud/vacumm/user.install.prereq.html
@doutriaux1 setuptools added to both as dependency - good catch, thanks |
@doutriaux1 I just checked and it seems that setuptools is available in the default python redhat install, same with OS X - so not sure it needs to be built.. Mind you, it is a pretty old version:
|
…dencies Issue423 durack1 fix vacumm dependencies
@doutriaux1 @aashish24 this should fix all the dependencies for vacumm - I'll just double check all these and will repost a comment here once I've confirmed all is ok - after confirmation I'd appreciate if you can merge..