Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue423 durack1 fix vacumm dependencies #1089

Merged
merged 7 commits into from
Mar 4, 2015
Merged

Issue423 durack1 fix vacumm dependencies #1089

merged 7 commits into from
Mar 4, 2015

Conversation

durack1
Copy link
Member

@durack1 durack1 commented Feb 26, 2015

@doutriaux1 @aashish24 this should fix all the dependencies for vacumm - I'll just double check all these and will repost a comment here once I've confirmed all is ok - after confirmation I'd appreciate if you can merge..

@durack1
Copy link
Member Author

durack1 commented Feb 26, 2015

@doutriaux1 @aashish24 ok this looks fine (just double checked the dependencies for configobj and six and confirmed they're ok) - so please merge once you've reviewed.

@doutriaux1 I'm not sure that six has a dependency on pip - which is what was already in the file six_deps.cmake - its setup.py lists no dependencies..

@aashish24
Copy link
Contributor

Okay, I will review it in next few hours and will get it merged..

@durack1
Copy link
Member Author

durack1 commented Feb 27, 2015

@aashish24 great, as noted above it could be a good idea to confirm the dependencies for six, I think pip can be removed..

@durack1
Copy link
Member Author

durack1 commented Feb 28, 2015

@aashish24 @doutriaux1 let's wait with this PR until we get an all clear from @stefraynaud, apparently pytz was needed in the most recent vacumm version.

@durack1
Copy link
Member Author

durack1 commented Mar 2, 2015

@stefraynaud, so we currently have:
set(vacumm_deps ${python_pkg} ${numpy_pkg} ${scipy_pkg} ${matplotlib_pkg} ${basemap_pkg} ${configobj_pkg}) as dependencies, if we add pytz will that be enough to get reasonable functionality from the package - the sphinx dependencies to compile documentation I don't think is needed and seawater v3.3.2 is already in..

In particular it's not clear to me whether paramiko, xlw or PIL are required?

For reference: http://relay.actimar.fr/~raynaud/vacumm/user.install.prereq.html

@stefraynaud
Copy link
Contributor

@durack1 I will commit a 2.5.1 version tomorrow that will remove the dependency to pytz.
So, as you said, set(vacumm_deps ${python_pkg} ${numpy_pkg} ${scipy_pkg} ${matplotlib_pkg} ${basemap_pkg} ${configobj_pkg}) is sufficient to have access to most of the library, and sphinx contribs are not needed.

paramiko, xlw or PIL are not required.

@durack1
Copy link
Member Author

durack1 commented Mar 2, 2015

@stefraynaud great thanks for clarifying, I'll download your 2.5.1 sources and update the tar ball on the server when it's available and then this PR should be good to go..

@doutriaux1
Copy link
Contributor

@durack1 since we provide sphinx why not add it to the dep list? It will only change the order in which it is built and should give us a more complete version in case @stefraynaud checks for it at install time. Same for seawater

@durack1
Copy link
Member Author

durack1 commented Mar 2, 2015

@doutriaux1 the additional packages are not included in the existing ALL builds: sphinxcontrib-cheeseshop 0.2, sphinxcontrib-ansi 0.6, sphinxcontrib-programoutput 0.8

@doutriaux1
Copy link
Contributor

I see

@stefraynaud
Copy link
Contributor

@durack1 Vacumm 2.5.1 is released.
@doutriaux1, there are currently no check at install time, despite numpy is needed by setup.py. Sphinx contribs are needed only to build the documentation.

@durack1
Copy link
Member Author

durack1 commented Mar 3, 2015

@stefraynaud I'll pull down the upddate tarball and revise the PR today, hopefully this might sneak under the 2.2 milestone..

@doutriaux1
Copy link
Contributor

@durack1 I will try to out it in

@durack1
Copy link
Member Author

durack1 commented Mar 3, 2015

@doutriaux1 it's updated and good to go!

@@ -0,0 +1 @@
set(vacumm_deps ${python_pkg} ${numpy_pkg} ${scipy_pkg} ${matplotlib_pkg} ${basemap_pkg} ${configobj_pkg})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no seawater?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no setuptools? if there's a setup.py it probably needs setuptools (distutils)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seawater isn't a hard dependency - only for advanced diags: http://relay.actimar.fr/~raynaud/vacumm/user.install.prereq.html

@durack1
Copy link
Member Author

durack1 commented Mar 3, 2015

@doutriaux1 setuptools added to both as dependency - good catch, thanks

@durack1
Copy link
Member Author

durack1 commented Mar 4, 2015

@doutriaux1 I just checked and it seems that setuptools is available in the default python redhat install, same with OS X - so not sure it needs to be built..

Mind you, it is a pretty old version:

[durack1@oceanonly ~]$ which python
/usr/bin/python
[durack1@oceanonly ~]$ python
Python 2.6.6 (r266:84292, Nov 21 2013, 10:50:32) 
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>> setuptools.__version__
'0.6'
[durack1m1:~] durack1% python
Python 2.7.5 (default, Mar  9 2014, 22:15:05) 
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import setuptools
>>> setuptools.__version__
'0.6c12'

doutriaux1 added a commit that referenced this pull request Mar 4, 2015
…dencies

Issue423 durack1 fix vacumm dependencies
@doutriaux1 doutriaux1 merged commit 8b03872 into CDAT:master Mar 4, 2015
@durack1 durack1 deleted the issue423_durack1_FixVacummDependencies branch April 1, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants