Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VACUMM to UV-CDAT #423

Closed
stefraynaud opened this issue Apr 2, 2014 · 16 comments
Closed

Add VACUMM to UV-CDAT #423

stefraynaud opened this issue Apr 2, 2014 · 16 comments
Assignees
Milestone

Comments

@stefraynaud
Copy link
Contributor

How about adding VACUMM to UV-CDAT since mandatory dependecies are already satisfied ?
Here is the up-to-date web site: http://relay.actimar.fr/~raynaud/vacumm/ (the officiel one is http://www.ifremer.fr/vacumm).
It makes an intensive usage of (UV-)CDAT and may have its place here too.

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Apr 2, 2014
@doutriaux1
Copy link
Contributor

I like this idea! Adding this to 2.0 milestone. Will let you know as soon as I have added it to the build, so that you can test it.

@doutriaux1
Copy link
Contributor

I'm fine with using the tarball. But if you want to switch to git repo then we can use that as well/instead

@stefraynaud
Copy link
Contributor Author

The management of VACUMM also depends on the IFREMER side, and they have not git on their forge.
Thus, lets work on tarballs for the moment.

VACUMM also used a few other optional packages:

  • paramiko (for SSH connexions).
  • xlwt (that usually goes with xlrd and xlutils).

@doutriaux1
Copy link
Contributor

Do these need to be installed BEFORE we install VACCUM or can they be installed after the fact?

@stefraynaud
Copy link
Contributor Author

They can be installed AFTER because they are optional.

@aashish24
Copy link
Contributor

@stefraynaud I am ok with adding this to the UV-CDAT if by default it would be Off. We are trying to downsize the core packages of UV-CDAT so that it is more accessible. I hope you understand. Thanks for the suggestion.

@stefraynaud
Copy link
Contributor Author

Ok, no problem.

What would be a reasonable maximal size for allowing a new package?

@doutriaux1
Copy link
Contributor

I think it is more about the number of dependencies it brings in rather than the size. Any pure python will most likely be fine. If I had to put a "size limit" I guess I'd say no worries up to 5Mb, 15-20Mb would start to trigger some attention, above that it would probably need to be widely used.

@aashish24 aashish24 removed this from the 2.0.0 milestone Jul 16, 2014
@doutriaux1 doutriaux1 added this to the 2.1 milestone Oct 17, 2014
@doutriaux1 doutriaux1 modified the milestones: 2.2, 2.1 Nov 10, 2014
@doutriaux1 doutriaux1 modified the milestones: 2.3, 2.2 Feb 21, 2015
@doutriaux1 doutriaux1 self-assigned this Feb 21, 2015
@durack1
Copy link
Member

durack1 commented Feb 24, 2015

@doutriaux1 you might want to review this and reset it back to a 2.2 milestone if all goes well with travis

@durack1
Copy link
Member

durack1 commented Feb 26, 2015

@doutriaux1 @aashish24 this also requires configobj and six to be installed - I'll issue another PR to bring this right up to date tomorrow

@durack1
Copy link
Member

durack1 commented Feb 26, 2015

@doutriaux1 @aashish24 this issue should really be reopened until I've solved these additional dependencies..

@aashish24 aashish24 reopened this Feb 26, 2015
@aashish24
Copy link
Contributor

Ah, I checked the setup.py and I didn't see those requirements. Should I revert the merge?

@aashish24 aashish24 reopened this Feb 26, 2015
@aashish24
Copy link
Contributor

Okay, I have reset so that it is no longer in master now.

@durack1
Copy link
Member

durack1 commented Feb 26, 2015

@aashish24 @doutriaux1 great, I'll fix this up and reissue a PR to bring things inline..

@durack1
Copy link
Member

durack1 commented Feb 27, 2015

@aashish24 @doutriaux1 this should be good to go #1089

@durack1
Copy link
Member

durack1 commented Feb 28, 2015

@aashish24 @doutriaux1 let's wait with #1089 until we get an all clear from @stefraynaud, apparently pytz was needed in the most recent vacumm version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants