-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VACUMM to UV-CDAT #423
Comments
I like this idea! Adding this to 2.0 milestone. Will let you know as soon as I have added it to the build, so that you can test it. |
I'm fine with using the tarball. But if you want to switch to git repo then we can use that as well/instead |
The management of VACUMM also depends on the IFREMER side, and they have not git on their forge. VACUMM also used a few other optional packages:
|
Do these need to be installed BEFORE we install VACCUM or can they be installed after the fact? |
They can be installed AFTER because they are optional. |
@stefraynaud I am ok with adding this to the UV-CDAT if by default it would be Off. We are trying to downsize the core packages of UV-CDAT so that it is more accessible. I hope you understand. Thanks for the suggestion. |
Ok, no problem. What would be a reasonable maximal size for allowing a new package? |
I think it is more about the number of dependencies it brings in rather than the size. Any pure python will most likely be fine. If I had to put a "size limit" I guess I'd say no worries up to 5Mb, 15-20Mb would start to trigger some attention, above that it would probably need to be widely used. |
@doutriaux1 you might want to review this and reset it back to a 2.2 milestone if all goes well with travis |
@doutriaux1 @aashish24 this also requires configobj and six to be installed - I'll issue another PR to bring this right up to date tomorrow |
@doutriaux1 @aashish24 this issue should really be reopened until I've solved these additional dependencies.. |
Ah, I checked the setup.py and I didn't see those requirements. Should I revert the merge? |
Okay, I have reset so that it is no longer in master now. |
@aashish24 @doutriaux1 great, I'll fix this up and reissue a PR to bring things inline.. |
@aashish24 @doutriaux1 this should be good to go #1089 |
@aashish24 @doutriaux1 let's wait with #1089 until we get an all clear from @stefraynaud, apparently pytz was needed in the most recent vacumm version. |
How about adding VACUMM to UV-CDAT since mandatory dependecies are already satisfied ?
Here is the up-to-date web site: http://relay.actimar.fr/~raynaud/vacumm/ (the officiel one is http://www.ifremer.fr/vacumm).
It makes an intensive usage of (UV-)CDAT and may have its place here too.
The text was updated successfully, but these errors were encountered: