Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assignment into an xpose_data object while maintaining the class #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

billdenney
Copy link
Contributor

This PR allows assignment into an xpdb object like the following while maintaining the "xpose_data" class. It replaces #135 and #139 and is rebased to the current master.

xpdb$foo <- "bar"

or

xpdb[["foo"]] <- "bar"

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #153 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #153      +/-   ##
=========================================
+ Coverage    94.4%   94.4%   +<.01%     
=========================================
  Files          40      40              
  Lines        3055    3058       +3     
=========================================
+ Hits         2884    2887       +3     
  Misses        171     171
Impacted Files Coverage Δ
R/xpose_data.R 98.43% <ø> (ø) ⬆️
R/xpdb_edits.R 88% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4187bf5...4e534ed. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant