Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Margins table and disable getMarginsImpacts from multi-regional models #290

Closed
WesIngwersen opened this issue May 15, 2024 · 0 comments · Fixed by #288
Closed

Remove Margins table and disable getMarginsImpacts from multi-regional models #290

WesIngwersen opened this issue May 15, 2024 · 0 comments · Fixed by #288
Assignees
Labels
invalid This doesn't seem right

Comments

@WesIngwersen
Copy link
Collaborator

WesIngwersen commented May 15, 2024

While a two-region model are successfully create with a Margins table, this is just loading the Margins table from the national IO and applying it equally to both regions in the model. This is not throwing an error but it is creating a imbalance and was not intended.

Recommend remove Margins table from these models (only call it for single region models based on BEA IO for now) and return an error message if getMarginsImpacts is called for these models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants