RC review: Lock test file with commit instead of master #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
|
I don't disagree, but my preference is to keep it standard for all the example files in this package and point to the main/master rather than the commit. (1) I'm the owner/maintainer of the other repo and don't anticipate changes to this file, and (2) I've seen others and been burned myself by github urls changing - if that happens generally I'm more aware, my concern would be that something would change for commits and being non-standard it would be harder to detect. |
|
Ok sounds fair, I close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that providing the exact version of the test file may avoid problems in the future if the upstream Coastal_Ecological_Indicators is updated