Skip to content

Commit

Permalink
some CRAN comment updates
Browse files Browse the repository at this point in the history
  • Loading branch information
michaeldumelle committed Nov 6, 2023
1 parent 925760d commit b387ca4
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Authors@R: c(
family = "Isaak",
role = "ctb")
)
Description: Spatial statistical modeling and prediction for data on stream networks, including models based on in-stream distance (Ver Hoef, J.M. and Peterson, E.E., 2010. <DOI:10.1198/jasa.2009.ap08248>.) Models are created using moving average constructions. Spatial linear models, including explanatory variables, can be fit with (restricted) maximum likelihood. Mapping and other graphical functions are included.
Description: Spatial statistical modeling and prediction for data on stream networks, including models based on in-stream distance (Ver Hoef, J.M. and Peterson, E.E., (2010) <DOI:10.1198/jasa.2009.ap08248>.) Models are created using moving average constructions. Spatial linear models, including explanatory variables, can be fit with (restricted) maximum likelihood. Mapping and other graphical functions are included.
License: GPL-3
Encoding: UTF-8
LazyData: true
Expand Down
10 changes: 9 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
Thank you very much for all the time and effort the CRAN team puts into maintaining
packages and assuring their high quality.

We have done our absolute best to address each point CRAN set regarding our initial submission.
We have done our best to sufficiently address each point CRAN sent regarding our initial submission.
A point-by-point response to each comment is provided below and has been incorporated into the revised submission.

## Revised CRAN Submission

* Please write references in the description of the DESCRIPTION file in the form authors (year) <doi:...> So please write the year in brackets.
* The relevant reference now reads Ver Hoef, J.M. and Peterson, E.E., (2010) <DOI:10.1198/jasa.2009.ap08248>.

* Size of tarball: 7201753 bytes A CRAN package should not be larger than 5 MB.
Please reduce the size.
* The CRAN package is now smaller than 5 MB (as indicated by `devtools::check()`)
Expand All @@ -24,6 +27,11 @@ Instead of `print()/cat()` rather use `message()/warning()` or
`if(verbose)cat(..) (or maybe stop())` if you really have to write text to the console. (except for print, summary, interactive functions) -> `R/createBinaryID.R`; `R/ssn_create_distmat.R`, ...
* We have removed the use of `print()` and `cat()` (outside of print, summary, interactive functions) and replaced with `message()` or `warning()`


* Please ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace (including the package directory and getwd()). This is not allowed by CRAN policies.
Please omit any default path in writing functions. In your examples/vignettes/tests you can write to `tempdir()`.
* No functions write by default to the user's home filespace, and our examples/vignettes/tests write to `tempdir()`.


* Please make sure that you do not change the user's options, par or working directory. If you really have to do so within functions, please ensure with an *immediate* call of on.exit() that the settings are reset when the function is exited.
e.g.: -> `R/ssn_subset.R`; `R/ssn_write.R`; `R/createBinaryID.R` ...
Expand Down
2 changes: 1 addition & 1 deletion man/SSN2-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added src/SSN2.dll
Binary file not shown.
Binary file added src/init.o
Binary file not shown.
Binary file added src/test_fc_UNIX.o
Binary file not shown.

0 comments on commit b387ca4

Please sign in to comment.