Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#30 Create Unit Tests with Example Data #37

Merged
merged 27 commits into from
Apr 26, 2023
Merged

#30 Create Unit Tests with Example Data #37

merged 27 commits into from
Apr 26, 2023

Conversation

kurtdunham
Copy link
Contributor

Created unit tests for tcplPlot.R, and tcplLoadData.R, and tcplConf.R

To run all test files in the test directory, use:

devtools::test()

To run the test files for a specific function, use:

usethis::use_test("tcplPlot")
devtools::test_active_file()

If the snapshot test image changes and needs review, use:

testthat::snapshot_review('tcplPlot/')

Dunham added 21 commits March 23, 2023 09:13
resolve merge conflict between bitbucket and github
a2003ab
resolve merge conflict tcplLoadData
705f6e6
removed browser and added error for invalid input
2c82ef0
Merge commit '2c82ef0c604264e4f11027ace153c9f948b63e0a' into 30-creat…
1872c05 
…e-unit-tests-with-example-data
resolve merge conflict tcplLoadData
953cc0f
initial testthat files
5be2764
updated tcplConf and tcplLoadData test files for output and error mes…
3b08e0d 
…sages
resolve merge conflict tcplLoadData
2a8be7e
initial testthat files
90a682f
updated tcplConf and tcplLoadData test files for output and error mes…
658c02f 
…sages
Merge branch '30-create-unit-tests-with-example-data' of https://gith…
15ac4df 
…ub.com/USEPA/CompTox-ToxCast-tcpl into 30-create-unit-tests-with-example-data
updated test-tcplLoadData tests to support return function and added …
35b1748 
…error for invalid lvl and type combiation
added helper-functions.R file to tests/testthat, added test for round…
fce3942 
…_n function works based on TOX-581 PR tests
added test-tcplPlot.R unit tests
3664572
added tcplPlot unit tests, isolated error message unit tests
89d8ebe
resolve remote merge conflict
9d4e6aa
added agg to mc and sc example data, updated unit tests for tcplPlot
511f122
resolve remote merge conflict
15a7fb5
updated tcplLoadData test files
4911e05
updated tcplPlot unit tests and created snapshot test
d27faa1
updated snapshot test
fbe088c
@kurtdunham kurtdunham linked an issue Apr 17, 2023 that may be closed by this pull request
Create Unit tests with example data #30
Closed
Dunham and others added 2 commits April 18, 2023 16:38
changed aes(x=0) to x=-Inf to avoid warning message: "Transformation …
a237bee 
…introduced infinite values in continuous x-axis", added unit test for no warning message
@brown-jason
added vdiffr to description
341ef57
brown-jason
brown-jason reviewed Apr 25, 2023
View reviewed changes
tests/testthat/Rplots.pdf Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurtdunham what is the purpose of this file?

brown-jason
brown-jason approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@brown-jason brown-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with skip test for snapshot for now and will create ticket to investigate

@kurtdunham kurtdunham merged commit 7f0193c into main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brown-jason brown-jason brown-jason approved these changes

@madison-feshuk madison-feshuk Awaiting requested review from madison-feshuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Unit tests with example data
2 participants
@kurtdunham @brown-jason