291 release tcpl 320 #292
Merged
291 release tcpl 320 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools load_all from vignette
… and no api functionality
Closed
23 tasks
cthunes
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Looks good!
- documentation updates look great!
- devtools::check has 0 errors, warnings, and notes
- devtools::test has 2 skipped tests, the rest are passing
- resolved 41 warnings from dplyr select in tcplQueryAPI
- tested varmat function from @ examples
- works with a warning that resulted from missing sc data
- added a fix to resolve the warning and changed @ examples docs to use dtxsids which were tested in sc
- looked over and tested new API functionality in tcplMthdList
- added validation like the other tcplMthdXxxx functions for lvl and type
- manually tested comparison plotting with API connection which is properly outputting pdfs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look at the code I changed and pull down the code and test. Try things like plotting with api and tcplvarmat. also, everything should be passing devtools::check