First pass vignette updates for v3.2 release #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
I edited text throughout in minor ways to clarify.
Minor textual changes
Minor edits throughout - tcplfit2 (case sensitive), POD to potency estimates (so as not to confused with in vivo PODs), and some other textual edits.
More minor text updates on flag filtering.
delete "provided for the Hill and Gain Loss models" from ac50 explanation
Clarified some text around definitions of hit call, ac50, and cutoff
minor grammar edits
Updates to text for activity concentration at specified response and cutoff for read-ability.
text updates for clarity.
Minor updates to burst cytotox text
Updated cytotox burst text, see lines 304-309
…er small formatting changes corrected to text for consistancy, added better description of nmed_gtbl_pos/neg and related level 6 flags.
…er small formatting changes corrected to text for consistancy, added better description of nmed_gtbl_pos/neg and related level 6 flags.
…oxCast-tcpl into 210-size-cleanup
Merging after Ashley's review
Switching package load from devtools to library(tcpl)
madison-feshuk
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Vignette updates look good to me. @brown-jason okay to merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to add to this PR with more vignette updates. Updated #210 with what has been completed