Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed gnls filter #269

Merged
merged 3 commits into from
Jul 24, 2024
Merged

removed gnls filter #269

merged 3 commits into from
Jul 24, 2024

Conversation

brown-jason
Copy link
Collaborator

closes #47 #48 #197
Cannot replicate chemicals being filtered out
Removed gnls filter

@brown-jason brown-jason requested a review from a team July 16, 2024 13:58
@brown-jason brown-jason linked an issue Jul 16, 2024 that may be closed by this pull request
TOX-485 Chemical not populated in cytotox table even though there is data at mc4 #48
Closed
@madison-feshuk madison-feshuk linked an issue Jul 17, 2024 that may be closed by this pull request
Review tcplCytoPt chemical filters to ensure all chemicals have default cytotox values #197
Closed
Kelly-Carstens-EPA
Kelly-Carstens-EPA approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@Kelly-Carstens-EPA Kelly-Carstens-EPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed cytotox burst table and values look good, no NA's. Spot checked several cytotox lower bound values and compared to invitrodb v3.5. Values look comparable and slightly increased compared to previous versions. Approve PR.

@madison-feshuk madison-feshuk merged commit 28cb072 into dev Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelly-Carstens-EPA Kelly-Carstens-EPA Kelly-Carstens-EPA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@brown-jason @Kelly-Carstens-EPA @madison-feshuk