Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

235 247 248 206 api plotting and bug fixes #257

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

cthunes
Copy link
Contributor

@cthunes cthunes commented May 17, 2024

Closes #235. API plotting is now functional. Use ccdR dev branch to test out API plotting.
Closes #247. The obscure well types are now printed out properly
Closes #248. Added check whether "mc" or "sc"
Closes #206. Improved logic for single conc coff direction in both plotly and ggplot, more consistent and coff flipped for -1 hitcalls. However, to my knowledge there will be no way to print the coff in the correct direction unless we know which overwrite method was assigned.

@madison-feshuk
Copy link
Collaborator

Got the following error trying to plot via API for m4id == '1255004'

tcplPlot(type="mc", fld="m4id", val=unique(dat$m4id), output='console')
Error in mutate():
ℹ In argument: flag = ifelse(is.na(flag) || flag == "NULL", "None", paste(flag, collapse = ";\n")).
ℹ In row 1.
Caused by error in is.na(flag) || flag == "NULL":
! 'length = 2' in coercion to 'logical(1)'
Backtrace:

  1. tcpl::tcplPlot(...)
  2. base::ifelse(...)

Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API plotting seems to be working great, but getting the following warnings. May be something to suppress in the future re: #254

tcplPlot(type="mc", fld="m4id", val=c('749888','749006','749012','749024'), verbose=TRUE, output='pdf', yuniform = TRUE, flags=TRUE)

Warning: Removed 5 rows containing missing values (geom_function()).Warning: Removed 10 rows containing missing values (geom_function()).Warning: Removed 32 rows containing missing values (geom_segment()).Warning: Removed 32 rows containing missing values (geom_segment()).Warning: Removed 16 rows containing missing values (geom_segment()).Warning: Removed 16 rows containing missing values (geom_segment()).Warning: Removed 16 rows containing missing values (geom_segment()).Warning: Removed 16 rows containing missing values (geom_segment()).Warning: Removed 16 rows containing missing values (geom_segment()).Warning: Removed 16 rows containing missing values (geom_segment()).

This branch also resolves "Error in data$dsstox_substance_id <- paste0("Well type: ", wllt) :
object of type 'closure' is not subsettable" error

Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change worked with updated dev branch of ccdR

@cthunes cthunes merged commit bc90593 into dev Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants