220 update mc6 methods to use model_type, update descs, remove no.med.single.dir.gt.3bmad #222
Conversation
….single.dir.gt.3bmad
cthunes
requested review from
brown-jason,
sedavid01,
Kelly-Carstens-EPA,
madison-feshuk and
Ashley-Ko
There was a problem hiding this comment.
Logic looks great and seems to be working well in the file you posted. To bulk update the mc6 flags, probably easiest to run on workbench. UPDATE mc6_aeid SET mc_mthd_id= 20, modified_date=XX WHERE mc_mthd_id= 21;
Let's wait until next week when tox21 etc finish processing then we'll make these changes and reprocess all of mc6. @USEPA/toxcast please review the short flag descriptions in this file and let us know if any changes are needed
R/mc6_mthds.R
Outdated
| @@ -150,13 +150,16 @@ mc6_mthds <- function() { | |||
|
|
|||
| singlept.hit.high = function(mthd) { | |||
|
|
|||
| flag <- "Only highest conc above baseline, active" | |||
| flag <- "Active with only highest conc above baseline" | |||
There was a problem hiding this comment.
Should we add 3bmad to each of these for clarity? "Active with only highest conc above baseline (3*bmad)"
R/mc6_mthds.R
Outdated
| @@ -166,13 +169,16 @@ mc6_mthds <- function() { | |||
|
|
|||
| singlept.hit.mid = function(mthd) { | |||
|
|
|||
| flag <- "Only one conc above baseline, active" | |||
| flag <- "Active with one conc (not highest) above baseline" | |||
There was a problem hiding this comment.
Should we add 3bmad to each of these for clarity? "Active with one conc (not highest) above baseline (3*bmad)"
R/mc6_mthds.R
Outdated
| @@ -182,12 +188,15 @@ mc6_mthds <- function() { | |||
|
|
|||
| multipoint.neg = function(mthd) { | |||
|
|
|||
| flag <- "Multiple points above baseline, inactive" | |||
| flag <- "Inactive with multiple concs above baseline" | |||
There was a problem hiding this comment.
Should we add 3bmad to each of these for clarity? "Inactive with multiple concs above baseline (3*bmad)"
There was a problem hiding this comment.
For no.med.gt.3bmad, update flag desc as "No median responses above baseline (3*bmad)"
Made updates and tested/reprocessed level 6 with aeid 2524 (same from email chain) for which here are the plots which contain the flags. I added no.med.gt.3bmad because it was not already assigned.
aeid2524newflags.pdf
Since I removed no.med.single.dir.gt.3bmad (mc6_mthd_id = 21) there are 1198 aeids with that assigned which should now be reassigned to no.med.gt.3bmad (mc6_mthd_id = 20).
invitrodb will have to have all of level 6 completely reprocessed and no.med.single.dir.gt.3bmad (mc6_mthd_id = 21) needs to be removed from the mc6_mthds table.
Closes #220.