Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

196 overwrite osd during hitcalling #199

Merged
merged 7 commits into from
Jan 30, 2024

Conversation

brown-jason
Copy link
Collaborator

Method was created for level 5.

Could not be assigned ow_ method because ow_ methods only apply after hitcalling. This one was a bit weird because it needed to be applied after the coff but before hitcalling.

Also integrated new tcplloaddata into mc5.R

Pipelined 2771 as a test case and successfully wrote to db

@brown-jason brown-jason requested a review from a team January 30, 2024 15:27
@brown-jason brown-jason linked an issue Jan 30, 2024 that may be closed by this pull request
Copy link
Contributor

@Kelly-Carstens-EPA Kelly-Carstens-EPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added mc5 method 30 to aeid 2506 and re-processed the data. The branch successfully replaced the BMR with COFF for a case where the BMR was high.

@cthunes
Copy link
Contributor

cthunes commented Jan 30, 2024

Do we need to merge the tcplLoadData PR before this? Would there be any conflict?

@brown-jason
Copy link
Collaborator Author

This doesnt modify tcplloaddata so there should be no conflict.

@brown-jason brown-jason merged commit 7117804 into dev Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overwrite osd during hitcalling
3 participants