Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added modified_by to the new schema lvl 4 write function #183

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

brown-jason
Copy link
Collaborator

Please tcplRun your favorite aeid and confirm level 4 is populating the mc4.modified_by field in invitrodb

@brown-jason brown-jason requested a review from a team December 14, 2023 14:12
@brown-jason brown-jason linked an issue Dec 14, 2023 that may be closed by this pull request
Copy link
Contributor

@Kelly-Carstens-EPA Kelly-Carstens-EPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mc4 column 'modified_date' populated for aeid 3034 that I just re-processed in invitrodb. I see the column in MySQL Workbench mc4 table, but I do not see the column using tcplLoadData() in R. I used the 'add.fld=T' function and still do not see it.

mc4 <- tcplPrepOtpt(tcplLoadData(lvl = 4L, fld = 'aeid', val = 3034, type = 'mc', add.fld=T))

@brown-jason
Copy link
Collaborator Author

The mc4 column 'modified_date' populated for aeid 3034 that I just re-processed in invitrodb. I see the column in MySQL Workbench mc4 table, but I do not see the column using tcplLoadData() in R. I used the 'add.fld=T' function and still do not see it.

mc4 <- tcplPrepOtpt(tcplLoadData(lvl = 4L, fld = 'aeid', val = 3034, type = 'mc', add.fld=T))

Thanks Kelly, for now we never add those fields, but i think you make a good point about add.fld and I think when we update tcplloaddata the add.fld should be used in the way you described.

@brown-jason brown-jason merged commit ed2a11a into dev Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modified_by field is blank in mc4
2 participants