Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored cndx and repi code #134

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

brown-jason
Copy link
Collaborator

Idea is that within every acid, spid, wllt, srcf, apid grouping we should have a ranked index for each concentration and a replicate index within each conc.

@brown-jason brown-jason linked an issue Aug 23, 2023 that may be closed by this pull request
Copy link
Contributor

@cthunes cthunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be setting cndx and repi correctly now, tested on same example acid 2940, spid 1208990432. Love seeing 39 lines being trimmed to just 4!

Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Corrected cndx bug with padilla data processing!

@brown-jason brown-jason merged commit fcd4354 into main Sep 6, 2023
1 check passed
brown-jason added a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign mc1 concentration indices (cndx)
3 participants