Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mc5 fit categories diagram and text to processing vignette #66

Closed
madison-feshuk opened this issue Jun 8, 2023 · 1 comment · Fixed by #81 or #86
Closed

Add mc5 fit categories diagram and text to processing vignette #66

madison-feshuk opened this issue Jun 8, 2023 · 1 comment · Fixed by #81 or #86
Assignees
@Ashley-Ko
Labels
enhancement

Comments

@madison-feshuk
Copy link
Collaborator

madison-feshuk commented Jun 8, 2023 •
edited
Loading

The mc5 fit categories text and diagram had been removed from processing vignette while updated fitc were still under development. Text and a new diagram can be reintroduced given the updated fit categories.
Ashley-Ko added a commit that referenced this issue Jun 28, 2023
@Ashley-Ko
Updates for "Add mc5 fit categories diagram and text to processing vi…
22d3f4e 
…gnette #66"

- Included "Fit Categories" subsection to the Level 5 section of the Data Processing vignette
-  Added Fig5_mc_fitc.png (Fig 5) in fitc section
- Added text to describe Fig 5 & fitc
- Removed depreciated section on fitc
@Ashley-Ko Ashley-Ko linked a pull request Jun 28, 2023 that will close this issue
#66 Added mc5 fit categories diagram & text to processing vignette #81
Merged
Ashley-Ko added a commit that referenced this issue Jul 10, 2023
@Ashley-Ko
Merge pull request #81 from USEPA/29-update-mc5-fit-categories-table
b01d612 
#66 Added mc5 fit categories diagram & text to processing vignette
@madison-feshuk
Copy link
Collaborator Author

Reopening issue so fitc figure can be updated with final manuscript version. One reviewer noted that the “cannot determine” fitc designation is terminal and should be “grayed” out.

@Ashley-Ko Ashley-Ko linked a pull request Jul 10, 2023 that will close this issue
Changes made to reflect reviewer suggestion to gray out "CANNOT DETER… #86
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ashley-Ko Ashley-Ko

Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@madison-feshuk @Ashley-Ko