Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcplSubsetChid export_ready bug #128

Closed
madison-feshuk opened this issue Aug 22, 2023 · 2 comments
Closed

tcplSubsetChid export_ready bug #128

madison-feshuk opened this issue Aug 22, 2023 · 2 comments
Assignees
Labels

Comments

@madison-feshuk
Copy link
Collaborator

madison-feshuk commented Aug 22, 2023

Related to #110. tcplSubsetChid no longer works if export_ready column is not present in database. In past versions such as v3.5, the column was deleted prior to release. For v4.1, we kept the columns, but filtered tables to export_ready=1

image

Adding "export_ready=FALSE" does not resolve error

@cthunes
Copy link
Contributor

cthunes commented Sep 6, 2023

On prod_internal_invitrodb_v3_5, I was able to reproduce the error, however, setting export_ready to FALSE did resolve the error for me, as the text output suggests. Am I missing something while reproducing this error?

@madison-feshuk
Copy link
Collaborator Author

madison-feshuk commented Sep 6, 2023

https://github.com/USEPA/ToxCast-Internal/blob/main/invitrodb_v4_1_release/invitrodb_v4_1_release.Rmd#L119C1-L119C74

old.mc5 <- tcplPrepOtpt(tcplSubsetChid(tcplLoadData(lvl=5, type = 'mc')))

update default to export_ready=false for backwards compatibility... We will need to set for true when preparing for releases

@cthunes cthunes closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants