flexibilize types for partial_trace #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 80.40% 80.36% -0.04%
==========================================
Files 36 36
Lines 2281 2282 +1
==========================================
Hits 1834 1834
- Misses 447 448 +1 ☔ View full report in Codecov by Sentry. |
|
@araujoms Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently partial_trace does not accept Hermitian or Symmetric matrices, and always returns a ComplexF64 result, independent of the type of the input. This PR fixes both issues. I'm also adding a convenience method to allow calling it with
dim_2_keepbeing a integer instead of a vector.I hope you find it useful.