Replace mapping.emplace(K, V) with call to mapping.find(K) #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::unordered_map::emplace
always allocates anstd::pair<Key, Value>
on the heap, even if the key is already in the map. This patch replaces the call tostd::unordered_map::emplace
with a call tostd::unordered_map::find
and an additional call tostd::unordered_map::emplace
in the case that the object is not registered yet. In practice, the object should be in the versions map every time except the first time so the additional lookup is not significant.cereal::detail::Versions::find
was considerably slowed by those allocations in some cases. For example, the serialization time for the attached benchmark was improved by 37% after this change.Before:
After: