Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update packages #99

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fix/update packages #99

merged 2 commits into from
Nov 16, 2023

Conversation

dannyk3941
Copy link
Contributor

What's this PR do?

  1. Update workspace package.jsons with details that are needed for info when packages are published to npm registry
  2. Remove npm package from package/web-components dependencies
  3. Replace LICENSE in workspace to correct one
  4. Build react components from web-components

@netlify Netlify
Copy link

netlify bot commented Nov 16, 2023

✅ Deploy Preview for cbpds-vanilla-develop canceled.

Name Link
🔨 Latest commit e28ef54
🔍 Latest deploy log https://app.netlify.com/sites/cbpds-vanilla-develop/deploys/6556602a3420a50008921be5

dgibson666
dgibson666 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@dgibson666 dgibson666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dannyk3941 dannyk3941 merged commit 673d27b into develop Nov 16, 2023
3 checks passed
@dannyk3941 dannyk3941 deleted the fix/update-packages branch November 16, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgibson666 dgibson666 dgibson666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannyk3941 @dgibson666