Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/checklist horizontal #236

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Conversation

dgibson666
Copy link
Collaborator

  • Created multicol component for checklists and radiolist patterns and created standalone story with docs.
  • Created checklist and radiolist stories with vertical, horizontal, and multicol variants (moved under checkbox and radio respectively)
  • WIP Resize observer component. This did not meet my needs for horizontal check/radiolists, but I may revisit it in tables.
  • Other bugfixes:
    • Removed bottom border on last dropdown item when filtered
    • Add color CSS property to td and th to fix context issues on table
    • Added fieldId prop to checkbox and auto-generate ID if none specified to implement explicit label association.
    • Updated table story to fix context bugs, add action bar, and add an extra column for responsive testing on mobile

Copy link
Collaborator

@bagrub bagrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgibson666 dgibson666 merged commit c9b4ee9 into develop Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants