Toast component #217
Merged
Toast component #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgibson666
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Lots of code comments.
As noted, the buttons aren't readable in dark mode.
Also, there's no way to manually dismiss them. Is one of the buttons supposed to always be "dismiss"? Is it possible to have no buttons, since they are slotted? Probably should discuss some of this stuff.
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
dgibson666
reviewed
Oct 25, 2024
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.stories.tsx
Outdated
Show resolved
Hide resolved
dgibson666
reviewed
Oct 25, 2024
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.scss
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/cbp-toast/cbp-toast.stories.tsx
Outdated
Show resolved
Hide resolved
dgibson666
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of the CBP Toast component