tagUpdate #174
Merged
tagUpdate #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgibson666
requested changes
Aug 6, 2024
| @@ -26,33 +26,33 @@ cbp-tag { | |||
| cursor: default; | |||
| padding: 0 var(--cbp-space-3x); | |||
| text-align: center; | |||
| font-weight: var(--cbp-font-weight-medium); | |||
| font-weight: var(--cbp-font-size-subhead); | |||
There was a problem hiding this comment.
this is incorrect. This variable is a font size, which needs to be specified properly.
There was a problem hiding this comment.
The old font-weight is still needed though.
| @@ -44,7 +44,7 @@ const Template = ({ label, color, withIcon, context, sx }) => { | |||
| ${context && context != 'light-inverts' ? `context=${context}` : ''} | |||
| ${sx ? `sx=${JSON.stringify(sx)}` : ''} | |||
| > | |||
| ${Icon ? `<cbp-icon name="${Icon}" sx='{"margin-right":"var(--cbp-space-2x)"}'></cbp-icon>` : ''} | |||
| ${Icon ? `<cbp-icon name="${Icon}" size="0.75rem"sx='{"margin-right":"var(--cbp-space-1x)"}'></cbp-icon>` : ''} | |||
There was a problem hiding this comment.
Because the icon is the same size as the font size, you shouldn't need this. The default icon size is 1em, which is relative to the surrounding context. Fix the font size (above) and this fixes itself.
dgibson666
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to tag from design review