Fixes per code review feedback

US-CBP · Nov 15, 2023 · 8d6a377 · 8d6a377
1 parent db8f742
commit 8d6a377
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/packages/web-components/src/components/cbp-app/cbp-app.scss b/packages/web-components/src/components/cbp-app/cbp-app.scss
@@ -1 +1,2 @@
+/* Temporary workaround for verified Stencil bug; can use @use due to compilation error */
 @import 'reset', 'roboto', 'css-variables', 'core';
diff --git a/packages/web-components/src/components/cbp-button/cbp-button.stories.tsx b/packages/web-components/src/components/cbp-button/cbp-button.stories.tsx
@@ -91,18 +91,18 @@ const Template = ({ label, tag, type, href, rel, target, download, fill, color,
   return ` 
       <cbp-app>
       <cbp-button
-        ${tag !== 'button' ? 'tag="'+tag+'"' : ''}
+        ${tag !== 'button' ? `tag=${tag}` : ''}
         type="${type}"
-        ${href ? 'href="'+href+'"' : ''}
-        ${rel ? 'rel="'+rel+'"' : ''}
-        ${target ? 'target="'+target+'"' : ''}
-        ${download ? 'download="'+download+'"' : ''}
+        ${href ? `href=${href}` : ''}
+        ${rel ? `rel=${rel}` : ''}
+        ${target ? `target=${target}` : ''}
+        ${download ? `download=${download}` : ''}
         fill="${fill}"
         color="${color}"
-        ${variant !== 'default' ? 'variant="'+variant+'"' : ''}
-        ${accessibilityText ? 'accessibility-text="'+accessibilityText+'"' : ''}
-        ${disabled ? 'disabled="'+disabled+'"' : ''}
-        ${sx ? 'sx='+JSON.stringify(sx) : ''}
+        ${variant !== 'default' ? `variant=${variant}` : ''}
+        ${accessibilityText ? `accessibility-text=${accessibilityText}` : ''}
+        ${disabled ? `disabled=${disabled}` : ''}
+        ${sx ? `sx=${JSON.stringify(sx)}` : ''}
       >
         ${label}
       </cbp-button>

diff --git a/packages/web-components/src/components/cbp-container/cbp-container.stories.tsx b/packages/web-components/src/components/cbp-container/cbp-container.stories.tsx
@@ -37,11 +37,11 @@ export default {
     return ` 
         <cbp-app>
         <cbp-container
-          ${background ? 'background="'+background+'"' : ''}
-          ${textColor ? 'text-color="'+textColor+'"' : ''}
-          ${width ? 'width="'+width+'"' : ''}
-          ${margins ? 'margins="'+margins+'"' : ''}
-          ${sx ? 'sx='+JSON.stringify(sx) : ''}
+          ${background ? `background=${background}` : ''}
+          ${textColor ? `text-color=${textColor}` : ''}
+          ${width ? `width=${width}` : ''}
+          ${margins ? `margins=${margins}` : ''}
+          ${sx ? `sx=${JSON.stringify(sx)}` : ''}
         >
           ${content}
         </cbp-container>
Original file line number	Diff line number	Diff line change
		@@ -1 +1,2 @@
		/* Temporary workaround for verified Stencil bug; can use @use due to compilation error */
		@import 'reset', 'roboto', 'css-variables', 'core';