Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MSA and separated Metric from Dataset #226

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

nishaq503
Copy link
Collaborator

@nishaq503 nishaq503 commented Dec 4, 2024

This PR also contains the current code for reproducing the CAKES benchmarks for our submission to SIMODS after the first round of reviews.

@nishaq503 nishaq503 requested a review from ndaniels December 4, 2024 23:10
@nishaq503 nishaq503 force-pushed the refactor/metric-vs-data branch from 5c97ace to bec8bbf Compare January 18, 2025 07:03
@nishaq503 nishaq503 changed the title Added crate features and simplified lots of type signatures Added MSA and separated Metric from Dataset Jan 18, 2025
Copy link
Collaborator

@ndaniels ndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I see no blocking issues; obviously there is a lot of room to still improve documentation and avoid magic numbers in code.

@ndaniels ndaniels merged commit 75cf0c0 into URI-ABD:master Jan 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants