Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't prefer polling #426

Merged
merged 1 commit into from
May 19, 2020
Merged

don't prefer polling #426

merged 1 commit into from
May 19, 2020

Conversation

jkeat
Copy link
Member

@jkeat jkeat commented May 19, 2020

Description

  • Don't prefer polling for waitlist
  • the version of vue-socket.io we have requires a 1.x version of socket.io-client, which is apparently mostly compatible with the 2.x server-side socket.io we have, besides

it only (partly) breaks polling transport, so you can mix 1.x and 2.0 versions with websocket transport (which is the protocol used in the vast majority of cases)

Developer self-review checklist

  • Potentially confusing code has been explained with comments
  • No warnings or errors have been introduced; all known error cases have been handled
  • Any appropriate documentation (within the code, README.md, docs, etc) has been updated
  • All edge cases have been addressed

@jkeat jkeat requested a review from treystevens May 19, 2020 19:42
Copy link
Member

@treystevens treystevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jkeat jkeat merged commit 755aa78 into master May 19, 2020
@jkeat jkeat deleted the dont-prefer-polling branch May 19, 2020 20:36
@jkeat jkeat restored the dont-prefer-polling branch May 19, 2020 21:01
@jkeat jkeat deleted the dont-prefer-polling branch May 19, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants