fix: 반응형 페이지 breakpoint 수정 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaeyeon-yang
changed the title
ShinChanU
reviewed
Oct 2, 2023
| @@ -67,7 +67,7 @@ const HeaderContents = ({ isLoading, userRes }: HeaderContentsProps) => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <div className="flex justify-between items-center w-full my-8 relative lg:hidden"> | |||
| <div className="flex justify-between items-center w-full my-8 relative smMaxLg:hidden"> | |||
There was a problem hiding this comment.
음 smMaxLg 이 키워드를 smMaxLg: { max: "1024px", min: "360px" } 이렇게 tailwind에서 지정해놔서 소형 기기에서는 적용이 안 될 것 같아요. 1024px 아래부터 hidden을 적용하려면, 이전 코드가 더 맞을 것 같습니다.. ! 아래 처럼 헤더가 사라지지 않고 깨져서 나오네요.
There was a problem hiding this comment.
음 smMaxLg 이 키워드를
smMaxLg: { max: "1024px", min: "360px" }이렇게 tailwind에서 지정해놔서 소형 기기에서는 적용이 안 될 것 같아요. 1024px 아래부터 hidden을 적용하려면, 이전 코드가 더 맞을 것 같습니다.. ! 아래 처럼 헤더가 사라지지 않고 깨져서 나오네요.@chaeyeon-yang
감사합니다 수정했습니다!!
ShinChanU
approved these changes
Oct 3, 2023
|
머지하겠습니다 ~! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
작업 내용
Before
After
To Reviewers (참고 사항, 첨부 자료 등)