Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 회원가입 페이지 유효성검사 #147

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

LeeJSYS
Copy link
Contributor

@LeeJSYS LeeJSYS commented Sep 24, 2023

PR Type

  • 기능 개발 (Feature)
  • 코드 스타일 변경 (Code style update) (formatting, local variables)
  • 화면 작업 (Style, CSS)
  • 리팩토링 (no functional changes, no api changes)
  • 버그수정 (Bugfix)
  • 빌드, 배포 관련 변경 (Build, Deploy)
  • 문서 작업 (Docs)
  • 그 외 (ETC)

작업 내용

  • 이름, 전화번호 유효성검사
  • 전화번호 포맷팅 적용
  • 텍스트 눌러도 체크되도록 수정

Before

After

image image

To Reviewers (참고 사항, 첨부 자료 등)

@LeeJSYS LeeJSYS added the 📌 Feature feature label Sep 24, 2023
@LeeJSYS LeeJSYS self-assigned this Sep 24, 2023
@LeeJSYS LeeJSYS changed the title Feat/mypage/05 Feat: 회원가입 페이지 유효성검사 Sep 24, 2023
@heehminh
Copy link
Member

준석님 email 필드도 추가해야 할 것 같습니다!!
image

@LeeJSYS
Copy link
Contributor Author

LeeJSYS commented Sep 25, 2023

준석님 email 필드도 추가해야 할 것 같습니다!! image

@heehminh
이메일필드는 백엔드에서 로그인시 자동으로 이메일 정보 가져가기로해서 빼기로했습니다
소현님께도 공유 드렸습니다
확인해주셔서 감사합니다!!

@heehminh
Copy link
Member

@LeeJSYS

아하 그렇군요!! 알겠습니다~!

Copy link
Member

@chaeyeon-yang chaeyeon-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chaeyeon-yang chaeyeon-yang merged commit 15324e5 into UPbrella:develop Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants