Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPBGE: Add upbge version info to stats #767

Merged
merged 5 commits into from
Jul 30, 2018
Merged

UPBGE: Add upbge version info to stats #767

merged 5 commits into from
Jul 30, 2018

Conversation

lordloki
Copy link
Member

@lordloki lordloki commented Jul 29, 2018 •
edited
Loading

image

panzergame
panzergame reviewed Jul 29, 2018
View reviewed changes
source/blender/blenkernel/intern/blender.c Outdated
@@ -105,15 +106,25 @@ void BKE_blender_free(void)
free_nodesystem();
}

void BKE_blender_version_string(char *version_str, size_t maxncpy, short version, short subversion, bool v_prefix, bool include_subversion)
void BKE_blender_version_string(char *version_str, size_t maxncpy, short version, short subversion, bool v_prefix, bool include_subversion, bool upbge)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using a BKE_upbge_version_string ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, less intrusive

@lordloki lordloki merged commit 727c1fb into master Jul 30, 2018
@lordloki lordloki deleted the ge_upbge_stats branch August 10, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panzergame panzergame panzergame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lordloki @panzergame