UPBGE: Add the option to disable component execution on game start #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new option is at user preferences under system tab. The component execution is disable by default (similar to scripts).
|
thank you :D
…On Thu, May 24, 2018, 4:38 PM lordloki ***@***.***> wrote:
The new option is at user preferences under system tab. The component
execution is disable by default (similar to scripts).
------------------------------
You can view, comment on, or merge this pull request online at:
#694
Commit Summary
- UPBGE: Add the option to disable component execution on game start
File Changes
- *M* CMakeLists.txt
<https://github.com/UPBGE/blender/pull/694/files#diff-0> (3)
- *M* release/scripts/startup/bl_ui/space_userpref.py
<https://github.com/UPBGE/blender/pull/694/files#diff-1> (1)
- *M* source/blender/blenkernel/BKE_global.h
<https://github.com/UPBGE/blender/pull/694/files#diff-2> (2)
- *M* source/blender/blenkernel/intern/blender.c
<https://github.com/UPBGE/blender/pull/694/files#diff-3> (6)
- *M* source/blender/blenloader/CMakeLists.txt
<https://github.com/UPBGE/blender/pull/694/files#diff-4> (3)
- *M* source/blender/blenloader/intern/versioning_defaults.c
<https://github.com/UPBGE/blender/pull/694/files#diff-5> (6)
- *M* source/blender/makesdna/DNA_userdef_types.h
<https://github.com/UPBGE/blender/pull/694/files#diff-6> (1)
- *M* source/blender/makesrna/intern/rna_userdef.c
<https://github.com/UPBGE/blender/pull/694/files#diff-7> (14)
- *M* source/gameengine/Converter/BL_BlenderDataConversion.cpp
<https://github.com/UPBGE/blender/pull/694/files#diff-8> (20)
Patch Links:
- https://github.com/UPBGE/blender/pull/694.patch
- https://github.com/UPBGE/blender/pull/694.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#694>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG25WXRBKy2Pievsjfc-0PINN1yMAekfks5t10RfgaJpZM4UNKDl>
.
|
|
Nice patch, I accept it. Is there an advantage of using a separate flag for scripts and components ? |
|
Simply it is for adding more flexibility. |
panzergame
requested changes
May 25, 2018
| @@ -4041,6 +4048,13 @@ static void rna_def_userdef_system(BlenderRNA *brna) | |||
| "(unsafe with blend files from an untrusted source)"); | |||
| RNA_def_property_update(prop, 0, "rna_userdef_script_autoexec_update"); | |||
|
|
|||
| prop = RNA_def_property(srna, "use_components_auto_execute", PROP_BOOLEAN, PROP_NONE); | |||
| RNA_def_property_boolean_negative_sdna(prop, NULL, "flag", USER_COMPONENT_AUTOEXEC_DISABLE); | |||
| RNA_def_property_ui_text(prop, "Auto Run UPBGE Components", | |||
There was a problem hiding this comment.
You could rename "UPBGE Components" to "python components" as in the description.
Now it uses the same DEFINE as the python script auto-exec disable. As blend component executation on loading as component registration or component reloading are disable by default. Warning notifications were added to top-bar and console.
|
I reworked component auto-exec disable. Now it uses the same DEFINE as the python script auto-exec disable. As blend component execution on loading as component registration or component reloading are disable by default. Warning notifications were added to top-bar and console. |
panzergame
approved these changes
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the same DEFINE as the python script auto-exec disable. Therefore, scripts and components are enable/disable using the same check at user preferences.
As blend component execution on loading as component registration or component reloading are disable by default.
Warning notifications were added to top-bar and console.