HPC-9742 Modify button component style #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onitoxan
added
the
ready for review
unocha-hpc
approved these changes
Sep 11, 2024
Pl217
requested changes
Sep 11, 2024
| text-decoration: none; | ||
| background-color: ${(p) => p.theme.colors.pallete.gray.light}; | ||
| color: #fff; | ||
| } | ||
| &.${COLOR_CLS.neutral_light} { |
There was a problem hiding this comment.
This looks little out of place. You have added this definition where empty line was, which makes git report as single line was removed, while entire PR adds new code.
There is a certain order established in COLOR_CLS and it goes primary, primary_light, secondary, secondary_light, neutral, neutral_light, so I'd respect this order when using the variables and place neutral_light after secondary_light.
Not very important, but contributes to better readability.
Pl217
added
needs minor changes
We use MUI library to use various component, in this page: https://mui.com/system/getting-started/the-sx-prop/#borders > "The borderRadius property multiplies the value it > receives by the theme.shape.borderRadius value > (the default for this value is 4px)." So to mantain some uniformity, we will use the same border-radius in our button
Pl217
approved these changes
Sep 11, 2024
Pl217
added
ready for merge
unocha-hpc
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of PR
Description
For more information read info in ticket HPC-9742. This PR includes code for modifying and adding new styles to our existing button for it to have more cohesion with how we are styling our components.
How to test changes
Verify that the modified styles show up as expected.
TODO:
No todo