HPC-9578 Add Apollo Client #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Onitoxan
added
the
ready for review
unocha-hpc
approved these changes
Aug 21, 2024
unocha-hpc
approved these changes
Aug 22, 2024
unocha-hpc
approved these changes
Aug 22, 2024
unocha-hpc
approved these changes
Sep 3, 2024
unocha-hpc
approved these changes
Sep 11, 2024
unocha-hpc
approved these changes
Sep 19, 2024
unocha-hpc
approved these changes
Sep 19, 2024
unocha-hpc
approved these changes
Oct 8, 2024
manelcecs
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Everything looks good!
We'll need to rebase this branch with all the new work and previously merged work too.
The only thing pending is to do a pair session with you to review the functionality and next steps to do (such as what can do Apollo Server to help to reduce the payload or to maintain the same data structure/schema)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nature of PR
Description
Add Apollo client to make calls to GrapQL endpoints. Beside setting up Apollo client I added an
AbortSignalfor calls that are using our REST endpoints, like this when changing of page the petition gets cancelled.Out of the box Apollo will let us have a cache system, that's why I remove the abort signals from petitions using it, once they are made they will not repeat themselves and they will be accessed form the cache.
Apollo allow use to use their own hooks like
useQuery, but since we have already implemented in the project our owndataLoaderI was not sure what would be the best idea. Also, reusing ourdataLoadermakes the implementation easier with less changes.How to test changes
To test changes I feel the key places to look are:
model.tsI added Apollo client here and we should double check that this should be the place where it belongs, if it's not the case we need to see where would that be.TODO:
Maybe we could investigate what else could we do with Apollo Client, there is a TODO comment in the code that we could look into:
And I suppose Apollo offers some kind of solution for this. In any case, if we feel is the case we could open a ticket in the future.