Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPC-9502 Flow pages bugs #439

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from
Open

HPC-9502 Flow pages bugs #439

wants to merge 35 commits into from

Conversation

Onitoxan
Copy link
Contributor

@Onitoxan Onitoxan commented Apr 19, 2024 •
edited
Loading

DESCRIPTION

Fix bugs on Flow page mentioned in ticket HPC-9502, beside these, I found a few more bugs specific to the flows page:

  • Pagination fixed
  • Table sorting fixed
  • Tested Filters (Frontend is working fine, just missing some changes in backend)
  • Handle No results on tables
  • Show horizontal scroll of table on top and always visible
  • Fix XLXS data mapping

So this concludes Flow and Pending Flow pages for this task.

@Onitoxan Onitoxan requested a review from a team as a code owner April 19, 2024 09:52
@Onitoxan Onitoxan marked this pull request as draft April 19, 2024 10:36
unocha-hpc
unocha-hpc approved these changes Apr 19, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 19, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 22, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 22, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 22, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 22, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 23, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Onitoxan Onitoxan added the ready for review All comments have been addressed, and the Pull Request is ready for review label Apr 23, 2024
@Onitoxan Onitoxan marked this pull request as ready for review April 23, 2024 08:11
@Onitoxan Onitoxan changed the title HPC-9502 - DRAFT HPC-9502 Apr 23, 2024
unocha-hpc
unocha-hpc approved these changes Apr 26, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 26, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 29, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Onitoxan Onitoxan changed the title HPC-9502 HPC-9502 Flow page bugs Jul 23, 2024
@Onitoxan Onitoxan changed the title HPC-9502 Flow page bugs HPC-9502 Flow pages bugs Jul 23, 2024
@Onitoxan Onitoxan force-pushed the HPC-9502 branch 2 times, most recently from fed2a1e to 36599dc Compare July 31, 2024 10:55
unocha-hpc
unocha-hpc approved these changes Jul 31, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Jul 31, 2024
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Onitoxan
Handle empty table state
b2a1fea
@Onitoxan
Block XLXS download while Active status is set
9307c29
@Onitoxan
Fix flows non-sortable fields
eacb0c0
@Onitoxan
Update reject pending flows button
c3701f9
@Onitoxan
Edit date format to DD/MM/YYYY
cddd845
@Onitoxan
Modify some fields to not be sortable
65660b4
@Onitoxan
Block filter deletion of an initial value
d3c97d3
@Onitoxan
Fix showing multiple countries org table
887d6fd
@Onitoxan
Update error handling and fix subtle bugs
f6dcc65
@Onitoxan
Support adminLevel=1 locations in fields
e6a869f
@Onitoxan
Fix table overflows
9f12bc8
@Onitoxan
Change 'allowNegative' default behaviour
bf7e620
@Onitoxan
Fix ',' replacement fn
9b2212f
@Onitoxan
Add merge Organization and merge Keyword
2283d1c
@Onitoxan
Fix hover over organization table
5d34beb
@Onitoxan
Fix i18n text of tooltips
b5105b3
@Onitoxan
Add InfoAlert component and minor fix to export of MergeModal
f2f2b64
@Onitoxan
Modify flow dates to en-GB format (dd/mm/YYYY)
8a3b3c8
@Onitoxan
includeChildrenOfParkedFlows default to true
be0b501
@Onitoxan
Fix flow-table plan destination not being filtered
dff4591
@Onitoxan
Fix download flows
c1a554d
@Onitoxan
Add loading state to keywords and pendingFlowBulkReject
f19c475
@Onitoxan
Update async-autocomplete-field fetching data
73bf759
@Onitoxan
Fix pending flow location label bug
fa41538
@Onitoxan
Change field type for 'Source System Id'
1f7374f
@Onitoxan
Add success message
72c6d52
@Onitoxan
Remove duplicated useEffect
835bd65
@Onitoxan
Refactor io-ts codecs
e1a9445
@Onitoxan
Improve mock data implementation
47f5276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unocha-hpc unocha-hpc unocha-hpc approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Pl217 Pl217

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Onitoxan @unocha-hpc @Pl217