Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] Fix trainer compute_loss when evaluating/predicting if the loss updated the inputs in-place #2617

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[v3] Fix trainer compute_loss when evaluating/predicting if the loss updated the inputs in-place #2617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dee389
Recompute the features if return_output
tomaarsen Apr 25, 2024
b75d8e5
Add SimilarityFunction to __init__, increment dev version
tomaarsen Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sentence_transformers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "2.8.0.dev0"
__version__ = "3.0.0.dev0"
__MODEL_HUB_ORGANIZATION__ = "sentence-transformers"

import importlib
Expand All @@ -7,6 +7,7 @@
from .datasets import SentencesDataset, ParallelSentencesDataset
from .LoggingHandler import LoggingHandler
from .SentenceTransformer import SentenceTransformer
from .similarity_functions import SimilarityFunction
from .readers import InputExample
from .cross_encoder.CrossEncoder import CrossEncoder
from .trainer import SentenceTransformerTrainer
Expand All @@ -25,6 +26,7 @@
"SentencesDataset",
"ParallelSentencesDataset",
"SentenceTransformer",
"SimilarityFunction",
"InputExample",
"CrossEncoder",
"SentenceTransformerTrainer",
Expand Down
2 changes: 2 additions & 0 deletions sentence_transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ def compute_loss(
loss_fn.model = model
loss = loss_fn(features, labels)
if return_outputs:
# Get fresh features, as the loss function has likely modified them
features, _ = self.collect_features(inputs)
output = torch.cat([model(row)["sentence_embedding"][:, None] for row in features], dim=1)
return loss, output
return loss
Expand Down