Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit transformers requirement to be <4.35.0 #2348

Closed
wants to merge 3 commits into from
Closed

Edit transformers requirement to be <4.35.0 #2348

wants to merge 3 commits into from

Conversation

claudiatang-git
Copy link

With safetensors serialization being the default in transformers v4.35.0, transformers v4.35.0 is currently not compatible with the sentence-transformers library as is. sentence-transformers cannot load safetensor models as of now, only pytorch_model.bin (pickle)

@tomaarsen
Copy link
Collaborator

tomaarsen commented Nov 7, 2023

Hello!

SentenceTransformers can still load models with safetensors, so I don't think there is a need to restrict the maximum transformers version. See also #2345, which should improve the model loading such that loading a SentenceTransformer model no longer requires the full repository (potentially with multiple model files) to be downloaded.

  • Tom Aarsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants