-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD FEEDBACK ADDITIONAL FIELDS #553
Merged
rhys-burendo
merged 36 commits into
main
from
feat/CDD-2298-feedback-additional-field-type
Dec 20, 2024
Merged
ADD FEEDBACK ADDITIONAL FIELDS #553
rhys-burendo
merged 36 commits into
main
from
feat/CDD-2298-feedback-additional-field-type
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhys-burendo
requested changes
Nov 25, 2024
src/app/components/cms/Feedback/Fields/Checkboxes/CheckboxesField.tsx
Outdated
Show resolved
Hide resolved
…luesList as props
…st array not newline-separated strings
Temiakinsoto
force-pushed
the
feat/CDD-2298-feedback-additional-field-type
branch
from
November 29, 2024 11:54
d8ca154
to
a0431ac
Compare
…//github.com/publichealthengland/winter-pressures-frontend into feat/CDD-2298-feedback-additional-field-type
Quality Gate passedIssues Measures |
rhys-burendo
previously approved these changes
Dec 3, 2024
…//github.com/publichealthengland/winter-pressures-frontend into feat/CDD-2298-feedback-additional-field-type
luketowell
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and reviewed recent commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In wagtail there are a good number of field types supported that can be selected in the CMS. Currently for feedback we only use 'multiline' and 'radio' types. This PR implement other types, URL, EMAIL, NUMBER, DROPDOWN, CHECKBOX AND CHECKBOXES:
Fixes #CDD-2298
Type of change
How Has This Been Tested?
Checklist: