Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD FEEDBACK ADDITIONAL FIELDS #553

Merged
merged 36 commits into from
Dec 20, 2024

Conversation

Temiakinsoto
Copy link
Contributor

@Temiakinsoto Temiakinsoto commented Nov 25, 2024

Description

In wagtail there are a good number of field types supported that can be selected in the CMS. Currently for feedback we only use 'multiline' and 'radio' types. This PR implement other types, URL, EMAIL, NUMBER, DROPDOWN, CHECKBOX AND CHECKBOXES:

Fixes #CDD-2298

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit tests
  • Playwright e2e tests
  • Mobile responsiveness
  • Accessibility (i.e. Lighthouse audit)
  • Disabled JavaScript

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any styles in this change follow the 'STYLES.md' guide
  • My changes are progressively enhanced with graceful degredagation for older browsers and non-JavaScript users
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Nov 25, 2024

Unit tests coverage

Lines Statements Branches Functions
Coverage: 93%
91.97% (1787/1943) 80.93% (433/535) 89.28% (275/308)
Tests Skipped Failures Errors Time
519 0 💤 0 ❌ 0 🔥 16.451s ⏱️

@Temiakinsoto Temiakinsoto force-pushed the feat/CDD-2298-feedback-additional-field-type branch from d8ca154 to a0431ac Compare November 29, 2024 11:54
rhys-burendo
rhys-burendo previously approved these changes Dec 3, 2024
Copy link
Contributor

@luketowell luketowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and reviewed recent commits

@rhys-burendo rhys-burendo merged commit c565765 into main Dec 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants