[DO NOT MERGE] CDD-2091: Ordinance survey maps #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests coverage
|
8lane
force-pushed
the
feat/CDD-2091-OSMaps
branch
from
a1e8370 to
e24567d
Compare
8lane
force-pushed
the
feat/CDD-2091-OSMaps
branch
from
e24567d to
58c929f
Compare
8lane
commented
Jul 23, 2024
src/app/api/proxy/map/route.ts
Outdated
| token_type: z.string(), | ||
| }) | ||
|
|
||
| export async function POST() { |
There was a problem hiding this comment.
This is the server side api endpoint that handles the oauth request to OSM
8lane
commented
Jul 23, 2024
|
|
||
| const proxyResponseSchema = z.object({ token: z.string(), expiresIn: z.string() }) | ||
|
|
||
| async function getToken() { |
There was a problem hiding this comment.
This is the client side request handler responsible for hitting the proxy api endpoint. It receives the token and expiration in the response. It will also refetch automatically after the token has expired.
8lane
force-pushed
the
feat/CDD-2091-OSMaps
branch
from
46671d7 to
aa6f0ef
Compare
rhys-burendo
previously approved these changes
Jul 24, 2024
8lane
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adding Ordinance Survey Maps behind a feature toggle. Also sneaked in boundary restrictions to all maps so users can't pan or zoom outside of UK.