fix(DTFS2-7223): ensure registration number regex only accepts 8-character strings #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar-richardson-softwire
temporarily deployed
to
qa
GitHub Actions
Inactive
oscar-richardson-softwire
temporarily deployed
to
qa
GitHub Actions
Inactive
oscar-richardson-softwire
temporarily deployed
to
qa
GitHub Actions
Inactive
oscar-richardson-softwire
temporarily deployed
to
qa
GitHub Actions
Inactive
oscar-richardson-softwire
temporarily deployed
to
qa
GitHub Actions
Inactive
|
abhi-markan
approved these changes
Jun 12, 2024
oscar-richardson-softwire
deleted the
fix/DTFS2-7223/ensure-companies-house-registration-number-regex-only-accepts-8-character-strings
branch
abhi-markan
added a commit
that referenced
this pull request
Jun 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.21.3](v1.21.2...v1.21.3) (2024-06-12) ### Bug Fixes * **DTFS2-7223:** ensure registration number regex only accepts 8-character strings ([#943](#943)) ([18ba1c5](18ba1c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
The regex for Companies House registration numbers in MDM currently accepts 7 or 8 character strings, when in fact all valid registration numbers are 8-character strings. This is not a significant issue, as in DTFS (which consumes the /companies MDM endpoint) we restrict to 8 character strings, but we should still change this in MDM for consistency with DTFS.
Resolution ✔️