Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): added env variables to deployment #918

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

abhi-markan
Copy link
Contributor

Introduction ✏️

Ensure new environment variables are assigned during deployment.

Resolution ✔️

  • Added to deployment.yml.

Miscellaneous ➕

  • Consistent naming convention
  • Updated .env.sample
  • Removed postinstall script due to husky being part of development dependency.

Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@oscar-richardson-softwire oscar-richardson-softwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhi-markan abhi-markan merged commit eaf7fad into main Jun 4, 2024
14 checks passed
@abhi-markan abhi-markan deleted the fix/deployment branch June 4, 2024 19:40
abhi-markan added a commit that referenced this pull request Jun 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.21.1](v1.21.0...v1.21.1)
(2024-06-04)


### Bug Fixes

* **deployment:** added env variables to deployment
([#918](#918))
([eaf7fad](eaf7fad))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants